-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batchgroup from material templates #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duttenheim
force-pushed
the
batchgroup-from-material-templates
branch
3 times, most recently
from
May 7, 2024 08:51
6437d48
to
738454f
Compare
There is no longer a need to build a table of unique batch IDs since we now compile our materials. This also simplifies the batch lookup process and debugging slightly.
framescriptc is a new python script which converts frame scripts to code. This makes frame scripts easy to debug.
Gave up trying to avoid having the buffers and textures forward declared.
Use R9G9B9E5 for HDR buffers. Use SRGB for 8 bit output buffers. Change from using blit to copy on swap (for compute support)
In the future, we might want to consider removing these, especially in GraphicsFeatureUnit. Added a set of calls for running graphics commands before the views and after the views. Ideally, this should be done with a context, like LightContext, instead of having these silly callbacks.
Render target dimensions now contains a scale factor, which is necessary to scale down texture sampling in pixel shaders working in screen space.
Also give command buffers optional names for easier tracking
Fixed a bunch of compute queue swap issues. Renamed main framescript pass to Scene. Submissions are now sent in batches rather than per queue. Semaphores have debug names for easier tracking and debugging.
Duttenheim
force-pushed
the
batchgroup-from-material-templates
branch
from
August 14, 2024 16:01
a716c75
to
9c96720
Compare
…pported on nvidia...
This fixes some issues where volumetric fog would oversample outside of the viewport and produce blueish borders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.