Feature: Add cargo fmt check to github action #87
Conversation
| @@ -22,3 +22,5 @@ jobs: | |||
| run: cargo build --verbose | |||
| - name: Run tests | |||
| run: cargo test --verbose | |||
| - name: Check formatting | |||
| run: cargo fmt --check | |||
There was a problem hiding this comment.
Here's what I've been doing in my crates:
- name: Fmt
run: cargo fmt --all -- --check
Haven't checked what the difference is
There was a problem hiding this comment.
From cargo fmt --help:
--all
Format all packages, and also their local path-based dependencies
Since this repo only has a single package and no local dependencies, it should not make a difference.
There was a problem hiding this comment.
So i guess it will probably only be relevant if we want to add derive suport
| "Rollback Entities have checksum {:X}", | ||
| result.0 | ||
| ); | ||
| trace!("Rollback Entities have checksum {:X}", result.0); |
There was a problem hiding this comment.
Thanks for doing this. I kept tripping this change while I was working on the other PRs and kept reverting it since it wasn't a part of my current work!
|
A good change! Should |
|
While I love working with clippy, I am not sure it is correct to fail the build if clippy has something. Some of the warnings are not always necessary and I am not the biggest fan of putting clippy ignore annotations in the code. |
We already do this in the ggrs crate, I feel it should be done here, too.