Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add respawn-entity test #89

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johanhelsing
Copy link
Collaborator

No description provided.

Copy link
Contributor

@nezuo nezuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to add comment to the top of the test that says it's purpose is to make sure despawning and rollback don't cause a panic.

Comment on lines +40 to +41
// each frame, roll back and resimulate 5 frames back in time, and compare checksums
.with_check_distance(2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't a with_check_distance of 2 only resimulate 5 frames?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to increase it yes. I set it to to for a very minimal repro of the issue, but should revert that last commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized I mistyped my comment. I meant to say: "Won't a with_check_distance of 2 only resimulate 2 frames?" The comment says 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants