Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #4

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix build warnings #4

merged 1 commit into from
Feb 1, 2024

Conversation

macdrevx
Copy link
Collaborator

@macdrevx macdrevx commented Feb 1, 2024

Previously, the project had 5 build warnings:

Screenshot 2024-02-01 at 10 25 14 AM

This PR addresses these warnings.

  • The first two are addressed by specifying that two enums should use an architecture-dependent size. This fixes the first two warnings when casting from void * to the enum type.
  • The last 3 warnings are in generated code. Newer versions of the code generator appear to have resolved these warnings, but for now, I'm just making the casts explicit. If we update the gumbo version in the future, hopefully we'll get regenerated code that also addresses these issues.

@macdrevx macdrevx merged commit 7dc87f3 into master Feb 1, 2024
1 check passed
@macdrevx macdrevx deleted the fix-build-warnings branch February 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants