Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added banner to redirect to Orbiter when suitable #1235

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

fraincs
Copy link
Contributor

@fraincs fraincs commented Oct 24, 2023

Issue:

Summary

As we have two "similar" Design System there was a need to make sure everyone uses the right Design System.

What I did

Added a banner in the installation page warning users about which DS they should use.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 1a663d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fraincs fraincs requested a review from vicky-comeau October 24, 2023 20:09
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for sg-orbit ready!

Name Link
🔨 Latest commit 1a663d1
🔍 Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/6538268d8e73f30008ac5975
😎 Deploy Preview https://deploy-preview-1235--sg-orbit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for sg-storybook ready!

Name Link
🔨 Latest commit 1a663d1
🔍 Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/6538268d42aa3f0008082d75
😎 Deploy Preview https://deploy-preview-1235--sg-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vicky-comeau vicky-comeau self-requested a review October 24, 2023 20:14
@fraincs fraincs merged commit 7fcff3f into master Oct 25, 2023
4 checks passed
@fraincs fraincs deleted the feature/banner-redirect branch October 25, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants