-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/starting doc plateform #1
Conversation
|
✅ Deploy Preview for wl-untitled ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Our standard is to use PascalCase to name components files. layout.tsx -> Layout.tsx |
(To be compliant with our policies, this repository should be configured to get at least one reviewer approval before merging back into main) @alexasselin008 listed our policies here: https://github.com/workleap |
For the structure of the app, I based myself on the conventions of Nextjs. If we apply this convention in the structure of next we will end up with For everything that concerns the components |
The configurations are in place, once the project is public they will be applied. |
Got it, is there any specific reason for the project to not being public yet? For SOC2 compliance those policies must be in place through the whole development effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
It seems to have been merged with unresolved issues, is there a plan to address those? |
It seemed to me that all the issues were answered, what problem was not addressed? |
There are 12 issues marked as "Outdated" rather than "Resolved". It doesn't seems possible to link to specific comment. |
They are indicated as "Outdated" however they have been taken into account and modified. The status is added when code is pushed on the branch, I don't know if there is a way to change it by resolut. |
Good question, not sure!
What's you take on using Github Discussion for questions / discussions? This is something I am looking to push for every repo. I am wondering thought if it's overkill for repos like this one.
Did you try the |
I set it up and it worked well 👍🏻
In fact I created this repo with the intention of including the Design System Components, that's why it's a Monorepo. In this context I think that the implementation of Discussion is a good thing. |
Awesome, thanks for sharing :) |
No description provided.