Skip to content

Commit

Permalink
More stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
patricklafrance committed Dec 10, 2024
1 parent 637a668 commit fd8b0b4
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions packages/firefly-webpack-configs/src/defineConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export type Router = "react-router";

export interface Features {
router?: Router;
// msw?: boolean;
msw?: boolean;
i18next?: boolean;
environmentVariables?: boolean;
honeycomb?: boolean;
Expand Down Expand Up @@ -141,17 +141,15 @@ function getHoneycombSharedDependencies(isHost: boolean): ModuleFederationShared
function getFeaturesDependencies(features: Features, isHost: boolean) {
const {
router = "react-router",
// router,
// msw,
msw = true,
i18next,
environmentVariables,
honeycomb
} = features;

return {
...(router === "react-router" ? getReactRouterSharedDependencies(isHost) : {}),
...getMswSharedDependency(isHost),
// ...(msw ? getMswSharedDependency(isHost) : {}),
...(msw ? getMswSharedDependency(isHost) : {}),
...(i18next ? getI18nextSharedDependency(isHost) : {}),
...(environmentVariables ? getEnvironmentVariablesSharedDependencies(isHost) : {}),
...(honeycomb ? getHoneycombSharedDependencies(isHost) : {})
Expand Down

0 comments on commit fd8b0b4

Please sign in to comment.