-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for deferred routes registration #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklafrance
changed the title
Fix/prevent double login
feat: Add support for deferred routes registration
Oct 26, 2023
code-person
reviewed
Oct 26, 2023
code-person
approved these changes
Oct 26, 2023
alexasselin008
approved these changes
Oct 27, 2023
code-person
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new APIs to support deferred routes registration with the ultimate goal of conditionally adding routes based on feature flags.
What changed
@squide/core
ModuleRegisterFunction
type to accept afunction
as the return value.completeLocalModuleRegistrations
function to complete the second phase of the registration process for local modules.@squide/webpack-module-federation
completeRemoteModuleRegistrations
function to complete the second phase of the registration process for local remote modules.completeModuleRegistrations
function to executecompleteLocalModuleRegistrations
andcompleteRemoteModuleRegistrations
in a single call.useAreModulesRegistered
hook to re-render the application once all the modules are registered (but not ready).useAreModulesReady
hook to be complimentary to theuseAreModulesRegistered
hook when deferred registrations are registered. The hook is backward compatible and includes no breaking changes.features
section to the defineConfig functions options.What's next
AppRouter
component