Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Webpack RegEx stricter #167

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Make Webpack RegEx stricter #167

merged 2 commits into from
Oct 31, 2023

Conversation

tjosepo
Copy link
Member

@tjosepo tjosepo commented Oct 31, 2023

Closes #166

Changes:

  • Add the end-of-string $ token to the different Webpack RegEx. This helps us make sure we're targeting the extension, and solves the issue of .json files being recognized as a .js file.

@patricklafrance patricklafrance merged commit 55e0bd4 into gsoft-inc:main Oct 31, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surlacolline surlacolline surlacolline approved these changes

@patricklafrance patricklafrance patricklafrance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack test RegEx are too lenient
3 participants
@tjosepo @patricklafrance @surlacolline