Add support for 3.13, drop support for 3.8 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesozoic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 appears to have introduced some sort of change to how it handles classes with multiple bases, and that is causing problems with the
pydantic.v1shim that we use for backwards compatibility. See #394In 1d225f8 I attempted refactoring one of the more complicated base classes to not use multiple inheritance, but it turns out that was a red herring. The real culprit was
underscore_attrs_are_private = True, which changes pydantic's behavior in some way that causes problems on 3.13. I'm honestly still a bit puzzled why, but I am not sure I care too much. This branch fixes it.