Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored methods/properties for constructing URLs in the API #399

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

mesozoic
Copy link
Collaborator

This branch replaces the hodgepodge of something_url() methods on various classes with a .urls property that can contain both 'hardcoded' URLs (which are only calculated once per object) and URL-returning methods. It simplifies the namespace of each containing object and makes it clearer how to add more URLs in the future for any more API endpoints we need.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3dc0d35) to head (ec52015).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #399    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           27        27            
  Lines         3135      3242   +107     
==========================================
+ Hits          3135      3242   +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mesozoic mesozoic merged commit e11aab2 into gtalarico:main Nov 8, 2024
7 checks passed
@mesozoic mesozoic deleted the urls branch November 8, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant