-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support generic types in glib::object_subclass
#1286
Draft
andy128k
wants to merge
1
commit into
gtk-rs:main
Choose a base branch
from
andy128k:generic_subclass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Take a look at the license at the top of the repository in the LICENSE file. | ||
|
|
||
| use glib::subclass::prelude::*; | ||
|
|
||
| pub mod imp { | ||
| use std::marker::PhantomData; | ||
|
|
||
| use super::*; | ||
|
|
||
| #[repr(C)] | ||
| pub struct MyGenericInterface<T> { | ||
| parent: glib::gobject_ffi::GTypeInterface, | ||
| marker: PhantomData<T>, | ||
| } | ||
|
|
||
| impl<T> Clone for MyGenericInterface<T> { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| parent: self.parent, | ||
| marker: self.marker, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl<T> Copy for MyGenericInterface<T> {} | ||
|
|
||
| #[glib::object_interface] | ||
| unsafe impl<T: 'static> ObjectInterface for MyGenericInterface<T> { | ||
| const NAME: &'static str = "MyGenericInterface"; | ||
| } | ||
|
|
||
| pub trait MyGenericInterfaceImpl<T>: ObjectImpl + ObjectSubclass {} | ||
|
|
||
| pub struct MyGenericType<T> { | ||
| marker: PhantomData<T>, | ||
| } | ||
|
|
||
| #[glib::object_subclass] | ||
| impl<T: 'static> ObjectSubclass for MyGenericType<T> { | ||
| const NAME: &'static str = "MyGenericType"; | ||
| type Type = super::MyGenericType<T>; | ||
| type Interfaces = (super::MyGenericInterface<T>,); | ||
|
|
||
| fn new() -> Self { | ||
| Self { | ||
| marker: PhantomData, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl<T: 'static> ObjectImpl for MyGenericType<T> {} | ||
|
|
||
| impl<T: 'static> MyGenericInterfaceImpl<T> for MyGenericType<T> {} | ||
|
|
||
| pub trait MyGenericTypeImpl<T>: ObjectImpl + ObjectSubclass {} | ||
| } | ||
|
|
||
| glib::wrapper! { | ||
| pub struct MyGenericInterface<T: 'static>(ObjectInterface<imp::MyGenericInterface<T>>); | ||
| } | ||
|
|
||
| unsafe impl<I: imp::MyGenericInterfaceImpl<T>, T> IsImplementable<I> for MyGenericInterface<T> {} | ||
|
|
||
| glib::wrapper! { | ||
| pub struct MyGenericType<T: 'static>(ObjectSubclass<imp::MyGenericType<T>>) @implements MyGenericInterface<T>; | ||
| } | ||
|
|
||
| unsafe impl<I: imp::MyGenericTypeImpl<T>, T> IsSubclassable<I> for MyGenericType<T> {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Take a look at the license at the top of the repository in the LICENSE file. | ||
|
|
||
| use glib::subclass::prelude::*; | ||
|
|
||
| pub mod imp { | ||
| use super::*; | ||
| use std::marker::PhantomData; | ||
|
|
||
| pub struct MyGenericType<T>(PhantomData<T>); | ||
|
|
||
| #[glib::object_subclass] | ||
| impl<T: 'static> ObjectSubclass for MyGenericType<T> { | ||
| const NAME: &'static str = "MyGenericType"; | ||
| type Type = super::MyGenericType<T>; | ||
|
|
||
| fn new() -> Self { | ||
| MyGenericType(PhantomData::<T>) | ||
| } | ||
| } | ||
|
|
||
| impl<T: 'static> ObjectImpl for MyGenericType<T> {} | ||
| } | ||
|
|
||
| glib::wrapper! { | ||
| pub struct MyGenericType<T: 'static>(ObjectSubclass<imp::MyGenericType::<T>>); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look too close but I think this is currently unsound. There's only a single type registered for every
T, so you can currently safely cast between differentT. Not sure how that can be solved nicely.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, single type. Similar to generics in Java with type erasure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike in Java this is unsound here though :) In the simplest case, you could have a
MyObj<T>that stores aT, and then simply casting that betweenT: StringtoT: u32and the subclass couldn't know about that happening and accesses the value with the wrong type then.