-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT] Implement deletion for certifyVuln, hasSBOM and hasSLSA #1982
Conversation
Signed-off-by: pxp928 <[email protected]>
…rtifier Signed-off-by: pxp928 <[email protected]>
…ests have been updated to test deletion Signed-off-by: pxp928 <[email protected]>
FYI @semmet95 and @kanchan-dhamane we can do the same for arrango now too. Created an issue for the KeyValue backend update here: #1983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing, the delete failed due to runtime error: invalid memory address or nil pointer dereference
at guac/pkg/assembler/backends/ent/backend/sbom.go:542
for which I provided a partial fix (closing }
and formatting missing)
0e993a1
to
5c10c23
Compare
Signed-off-by: pxp928 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pxp928 thanks a lot: that's a great feature!
Description of the PR
Delete
functionality (limited tocertifyVuln
,hasSBOM
andhasSLSA
)Delete
via the graphQL clientDelete
for ENT backendPR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run