Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT] Implement deletion for certifyVuln, hasSBOM and hasSLSA #1982

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jun 26, 2024

Description of the PR

  • GraphQL updated to add Delete functionality (limited to certifyVuln, hasSBOM and hasSLSA)
  • Expose Delete via the graphQL client
  • Implement Delete for ENT backend
  • Add unit tests for the new delete functionality

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 requested review from jeffmendoza and lumjjb June 26, 2024 15:52
@pxp928
Copy link
Collaborator Author

pxp928 commented Jun 26, 2024

FYI @semmet95 and @kanchan-dhamane we can do the same for arrango now too. Created an issue for the KeyValue backend update here: #1983

Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing, the delete failed due to runtime error: invalid memory address or nil pointer dereference at guac/pkg/assembler/backends/ent/backend/sbom.go:542 for which I provided a partial fix (closing } and formatting missing)

pkg/assembler/backends/ent/backend/sbom.go Outdated Show resolved Hide resolved
@pxp928 pxp928 force-pushed the poc-delete-node branch 2 times, most recently from 0e993a1 to 5c10c23 Compare June 28, 2024 17:17
@pxp928 pxp928 force-pushed the poc-delete-node branch from 5c10c23 to 7776d9c Compare June 28, 2024 17:19
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pxp928 thanks a lot: that's a great feature!

@kodiakhq kodiakhq bot merged commit 6a63c22 into guacsec:main Jul 2, 2024
8 checks passed
@pxp928 pxp928 deleted the poc-delete-node branch July 2, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants