Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conditions from gem declarations in Gemfile #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove conditions from gem declarations in Gemfile #584

wants to merge 1 commit into from
+6 −19

Commits on Aug 6, 2024

  1. Remove conditions from gem declarations in Gemfile 

    Both gems 'wdm' and 'rb-kqueue' can be installed on any platform.
They fail when require 'wdm' or 'rb-kqueue' is called.
So the conditions in the Gemfile can be removed and should not be recommended.

Having conditions in the Gemfile is generally bad practice, since this leads to changed Gemfile.lock, whenever the bundler is executed on a different platform.
Also "bundle package --all-platforms" doesn't work properly, when gems are declared conditionally.
    @larskanis
    larskanis committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    067d277 View commit details
    Browse the repository at this point in the history