Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Prebid to 9.27.0 #1760

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Bump Prebid to 9.27.0 #1760

wants to merge 14 commits into from

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Jan 22, 2025 •
edited
Loading

What does this change?

Bumps version of @guardian/prebid.js to 9.27.0

Why?

Updating our Prebid fork to match the upstream 9.27.0

See major changes in https://github.com/prebid/Prebid.js/releases/tag/9.0.0

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c7a5108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cemms1 cemms1 force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch 2 times, most recently from ad0618d to d5cbd3f Compare January 23, 2025 10:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Deploy build 3116 of dotcom::commercial-bundle to CODE

All deployment options

From guardian/actions-riff-raff.

@cemms1 cemms1 force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch from 21c547d to 79d2368 Compare January 23, 2025 17:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Ad load time test results

For consented, top-above-nav took on average 4346ms to load.
For consentless, top-above-nav took on average 3083ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

cemms1
cemms1 commented Jan 23, 2025
View reviewed changes
src/lib/header-bidding/prebid/prebid.spec.ts
@@ -109,7 +108,7 @@ describe('initialise', () => {
},
},
],
auctionDelay: 0,
auctionDelay: 500,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prebid/Prebid.js@f675808. This was added as part of v9.0.0

src/lib/header-bidding/prebid/prebid.spec.ts
s2sConfig: {
adapter: 'prebidServer',
adapterOptions: {},
allowUnknownBidderCodes: false,
bidders: [],
maxBids: 1,
maxTimeout: 1500,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prebid/Prebid.js@8b2b415. This was added as part of v9.0.0

@emma-imber emma-imber force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch 2 times, most recently from 46235f0 to 695d236 Compare January 31, 2025 17:44
@cemms1 cemms1 force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch from 5323826 to c15d87d Compare February 4, 2025 09:26
@emma-imber emma-imber force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch from c15d87d to faf7503 Compare February 4, 2025 11:21
@cemms1 cemms1 mentioned this pull request Feb 5, 2025
Merged
@cemms1 cemms1 force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch from 44edaea to 73210fd Compare February 5, 2025 16:10
@cemms1 cemms1 mentioned this pull request Feb 5, 2025
Merged
@cemms1 cemms1 force-pushed the cemms1/upgrade-prebid-to-9.27.0 branch from 29b8089 to c7a5108 Compare February 5, 2025 17:40
@cemms1
Copy link
Contributor Author

cemms1 commented Feb 5, 2025

Testing first in #1784 before moving forward with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cemms1 @emma-imber