Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace commas with semicolons in Permutive setup with googletag #1786

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Feb 6, 2025

What does this change?

  • Replaces commas with semicolons
  • Moves eslint disable comments above the line they refer to

Why?

Was it a mistake that the permutive setup commands ended with commas instead of semicolons?

From when permutive was added (guardian/frontend@09675cc#diff-3553e1025635aeb071b2bfe8d9b01ee48d9d27adf6597350bf315f5dae03648b) it's always had commas instead of semicolons 🤔

This is unlikely to affect anything, since these commands probably still run fine with commas instead of semicolons, but this brings us closer to the way the docs recommend: https://developer.permutive.com/docs/ad-manager-dfp#javascript-changes

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 8ae8173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Ad load time test results

For consented, top-above-nav took on average 4279ms to load.
For consentless, top-above-nav took on average 3031ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@cemms1 cemms1 marked this pull request as ready for review February 6, 2025 12:19
@cemms1 cemms1 requested a review from a team as a code owner February 6, 2025 12:19
Copy link
Contributor

@dskamiotis dskamiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, easier to read, not sure of why commas in the first place!

@cemms1 cemms1 merged commit 9c09458 into main Feb 7, 2025
14 checks passed
@cemms1 cemms1 deleted the cemms1/permutive-formatting branch February 7, 2025 09:26
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @cemms1 1 minute and 35 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants