Replace commas with semicolons in Permutive setup with googletag #1786
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
Was it a mistake that the permutive setup commands ended with commas instead of semicolons?
From when permutive was added (guardian/frontend@09675cc#diff-3553e1025635aeb071b2bfe8d9b01ee48d9d27adf6597350bf315f5dae03648b) it's always had commas instead of semicolons 🤔
This is unlikely to affect anything, since these commands probably still run fine with commas instead of semicolons, but this brings us closer to the way the docs recommend: https://developer.permutive.com/docs/ad-manager-dfp#javascript-changes