Skip to content

Commit

Permalink
🦋 Release package updates (#55)
Browse files Browse the repository at this point in the history
Bump package versions

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] and github-actions[bot] authored Aug 19, 2022
1 parent 0f0888d commit fd93082
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 33 deletions.
31 changes: 0 additions & 31 deletions .changeset/spicy-bees-yawn.md

This file was deleted.

7 changes: 7 additions & 0 deletions packages/eslint-config-typescript/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @guardian/eslint-config-typescript

## 1.0.6

### Patch Changes

- Updated dependencies [0f0888d]
- @guardian/eslint-config@2.0.0

## 1.0.5

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-typescript/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@guardian/eslint-config-typescript",
"version": "1.0.5",
"version": "1.0.6",
"description": "ESLint config for Guardian TypeScript projects",
"main": ".eslintrc.js",
"dependencies": {
Expand Down
32 changes: 32 additions & 0 deletions packages/eslint-config/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# @guardian/eslint-config

## 2.0.0

### Major Changes

- 0f0888d: _tl;dr_

- linting for conformance with our `prettier` config is slow
- to speed up linting, we will stop doing that
- you should use `prettier` directly

### Before

We extended `plugin:prettier/recommended` which

1. used `eslint-config-prettier` to disable any white-space formatting rules that would conflict with our prettier config
2. used `eslint-plugin-prettier` to lint for formatting errors that did not match our prettier config

This is quite expensive, and although it means you could use `--fix` to apply prettier, it's not as fast as using prettier directly.

### After

We still use `eslint-config-prettier` to avoid conflicts with our `prettier` config, but we no longer lint for errors (and therefore also don't fix them).

### Recommendations

Use `prettier` directly, e.g.

- via [editor integration](https://prettier.io/docs/en/editors.html)
- via a [pre-commit hook](https://prettier.io/docs/en/precommit.html)

If you prefer the way this used to work, add the [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) manually to your ESLint config.

## 1.0.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@guardian/eslint-config",
"version": "1.0.2",
"version": "2.0.0",
"description": "ESLint config for Guardian JavaScript projects",
"main": ".eslintrc.js",
"dependencies": {
Expand Down

0 comments on commit fd93082

Please sign in to comment.