loadScript rejects with an Error

[arelra]

Background

The current most frequent error in Sentry, accounting for ~20% of DCR's errors is:

Non-Error exception captured with keys: currentTarget, isTrusted, target, type

This is a generic error from Sentry telling us that it requires rejected promises to return a proper Error:

getsentry/sentry-javascript#2546 (comment)

https://sentry.zendesk.com/hc/en-us/articles/360057389753-Why-am-I-seeing-events-with-Non-Error-exception-or-promise-rejection-captured-with-keys-using-the-JavaScript-SDK-

The errors look to be coming from loadScript given the serialised object reported by Sentry e.g.:

{
  currentTarget: [object Null], 
  isTrusted: True, 
  target: head > script#ipsos[type="text/javascript"], 
  type: error
}

{
  currentTarget: [object Null], 
  isTrusted: True, 
  target: head > script, 
  type: error
}

This change

Updates promise rejections to return an Error type.

Changing the promise rejection won't reduce the errors but it will give us better insight into the errors reported by Sentry.

I suspect the underlying errors are the result of ad-blockers but we can't be sure without more detailed errors.

Why?

To get better insight into high volume errors reported by Sentry

[changeset-bot]

🦋 Changeset detected

Latest commit: 9ebd68b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@guardian/libs	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[arelra]

@ob6160 @joecowton1

fyi the checks were stuck in pending status as a conversation was not resolved.

Once I resolved the conversation however the checks stayed stuck in a pending state 😢

I've done a no-edit commit and force pushed to kick it off again.

[joecowton1]

@ob6160 @joecowton1

fyi the checks were stuck in pending status as a conversation was not resolved.

Once I resolved the conversation however the checks stayed stuck in a pending state 😢

I've done a no-edit commit and force pushed to kick it off again.

Look ok now, let us know if its not!