Skip to content

Commit

Permalink
Use seperate grid layout for media cards
Browse files Browse the repository at this point in the history
  • Loading branch information
abeddow91 committed Jan 22, 2025
1 parent 00ea827 commit 7f2e661
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions dotcom-rendering/src/components/Masthead/HighlightsCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from '@guardian/source/foundations';
import { SvgCamera } from '@guardian/source/react-components';
import { ArticleDesign, type ArticleFormat } from '../../lib/articleFormat';
import { isMediaCard } from '../../lib/cardHelpers';
import { isMediaCard as isMedia } from '../../lib/cardHelpers';
import { palette } from '../../palette';
import type { StarRating as Rating } from '../../types/content';
import type { DCRFrontImage } from '../../types/front';
Expand Down Expand Up @@ -82,6 +82,20 @@ const gridContainer = css`
}
`;

const mediaGrid = css`
grid-template-areas:
'image'
'headline'
'media-icon';
${from.desktop} {
width: 300px;
grid-template-areas:
'image headline'
'image media-icon';
}
`;

const headline = css`
grid-area: headline;
`;
Expand Down Expand Up @@ -175,7 +189,7 @@ export const HighlightsCard = ({
galleryCount,
audioDuration,
}: HighlightsCardProps) => {
const showMediaIcon = isMediaCard(format);
const isMediaCard = isMedia(format);
const MediaPill = () => (
<div css={mediaIcon}>
{mainMedia?.type === 'Video' && (
Expand Down Expand Up @@ -205,7 +219,7 @@ export const HighlightsCard = ({
);
return (
<FormatBoundary format={format}>
<div css={[gridContainer, hoverStyles]}>
<div css={[gridContainer, hoverStyles, isMediaCard && mediaGrid]}>
<CardLink
linkTo={linkTo}
headlineText={headlineText}
Expand Down Expand Up @@ -241,7 +255,7 @@ export const HighlightsCard = ({
</div>
) : null}

{!!mainMedia && showMediaIcon && MediaPill()}
{!!mainMedia && isMediaCard && MediaPill()}

<div css={imageArea}>
{(avatarUrl && (
Expand Down

0 comments on commit 7f2e661

Please sign in to comment.