-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video timestamp pills on cards #13208
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: +856 B (+0.1%) Total Size: 888 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chromatic diffs look as expected to me, and the new rules look correctly implemented from testing locally, so 👍
Seen on PROD (merged by @abeddow91 10 minutes and 1 second ago) Please check your changes! |
What does this change?
Puts rules in place to determine to position of the timestamp pill for video on fronts for beta containers only.
The new rules state that if video media has a duration:
In addition, for consistency, this PR also updates the youtube block component so that it uses the pill component rather than its own implementation
Why?
There is a desire from design to visually distinguish video articles from articles that contain video.
Screenshots
Video Article
Article with Video