Applied Styles To The Football Match List #13244
Merged
+292
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the way it appears on frontend. Updated the stories to display more edge cases: narrow dates, uneven scores. Broke the component down into sub-components to which styles are applied. Added palette light and dark colours. Also made use of `Intl.DateTimeFormat` to handle formatting the dates and times with appropriate locales and timezones for the different editions. Added functions to the `edition` module to get the timezone and locale for a given edition. Co-authored-by: Marjan Kalanaki <[email protected]>
|
Size Change: +57 B (+0.01%) Total Size: 893 kB ℹ️ View Unchanged
|
So it can be used outside storybook. Co-authored-by: Marjan Kalanaki <[email protected]>
This is a style used more commonly across the codebase. Also stopped using `HTMLAttributes` to declare props. Co-authored-by: Marjan Kalanaki <[email protected]>
Each day is a `section` with a heading, not the whole component. Co-authored-by: Marjan Kalanaki <[email protected]>
`from` was an import and a function argument.
`span` was the name of the function and one of its parameters.
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (created by @JamieB-gu and merged by @marjisound 8 minutes and 49 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the way it appears on frontend. Updated the stories to display more edge cases: narrow dates, uneven scores. Broke the component down into sub-components to which styles are applied. Added palette light and dark colours.
Also made use of
Intl.DateTimeFormatto handle formatting the dates and times with appropriate locales and timezones for the different editions. Added functions to theeditionmodule to get the timezone and locale for a given edition.