-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show / Hide alignment #13252
Show / Hide alignment #13252
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: +12 B (0%) Total Size: 888 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen on PROD (merged by @abeddow91 8 minutes and 57 seconds ago) Please check your changes! |
What does this change?
Updates the alignment for show hide so that
Why?
The ability to show/hide containers is behind a sign in flag. The component is visually hidden with a class when the user is signed out. However the css still considers the controls container to have 2 children and so add space-between. By adding an additional check that neither children are hidden we ensure this rule is only applied when both children are rendered and visible.
These are design tweaks that have come out of QA.
This fixes both https://trello.com/c/flwh5FTG and https://trello.com/c/Pgh4oOhe
Screenshots