Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-dom from 17.0.2 to 18.2.0 in /dotcom-rendering #6787

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2022

Bumps react-dom from 17.0.2 to 18.2.0.

Release notes

Sourced from react-dom's releases.

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

React DOM Server

  • Fix escaping for the bootstrapScriptContent contents. (@​gnoff in #24385)
  • Significantly improve performance of renderToPipeableStream. (@​gnoff in #24291)

ESLint Plugin: React Hooks

Use Subscription

  • Replace the implementation with the use-sync-external-store shim. (@​gaearon in #24289)

18.0.0 (March 29, 2022)

... (truncated)

Changelog

Sourced from react-dom's changelog.

18.2.0 (June 14, 2022)

React DOM

React DOM Server

  • Pass information about server errors to the client. (@​salazarm and @​gnoff in #24551 and #24591)
  • Allow to provide a reason when aborting the HTML stream. (@​gnoff in #24680)
  • Eliminate extraneous text separators in the HTML where possible. (@​gnoff in #24630)
  • Disallow complex children inside <title> elements to match the browser constraints. (@​gnoff in #24679)
  • Fix buffering in some worker environments by explicitly setting highWaterMark to 0. (@​jplhomer in #24641)

Server Components (Experimental)

18.1.0 (April 26, 2022)

React DOM

React DOM Server

  • Fix escaping for the bootstrapScriptContent contents. (@​gnoff in #24385)
  • Significantly improve performance of renderToPipeableStream. (@​gnoff in #24291)

ESLint Plugin: React Hooks

Use Subscription

  • Replace the implementation with the use-sync-external-store shim. (@​gaearon in #24289)

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by gnoff, a new releaser for react-dom since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) from 17.0.2 to 18.2.0.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v18.2.0/packages/react-dom)

---
updated-dependencies:
- dependency-name: react-dom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner December 14, 2022 18:04
@dependabot dependabot bot added the DCR Dependency Dependency for DCR project label Dec 14, 2022
@mxdvl
Copy link
Contributor

mxdvl commented Dec 19, 2022

This feels like something that should be done all at once, both react and react-dom

@mxdvl mxdvl requested a review from a team December 19, 2022 10:15
@github-actions
Copy link

Size Change: -250 kB (-10%) 👏

Total Size: 2.29 MB

Filename Size Change
dotcom-rendering/dist/1423.modern.********************.js 0 B -3.53 kB (removed) 🏆
dotcom-rendering/dist/1522.legacy.********************.js 0 B -4.01 kB (removed) 🏆
dotcom-rendering/dist/2635.modern.********************.js 0 B -6.33 kB (removed) 🏆
dotcom-rendering/dist/2727.legacy.********************.js 0 B -4.28 kB (removed) 🏆
dotcom-rendering/dist/2850.legacy.********************.js 0 B -10.2 kB (removed) 🏆
dotcom-rendering/dist/2850.modern.********************.js 0 B -10.5 kB (removed) 🏆
dotcom-rendering/dist/290.legacy.********************.js 10.3 kB -2.72 kB (-21%) 🎉
dotcom-rendering/dist/3107.legacy.********************.js 0 B -6.07 kB (removed) 🏆
dotcom-rendering/dist/3107.modern.********************.js 0 B -5.94 kB (removed) 🏆
dotcom-rendering/dist/3178.legacy.********************.js 0 B -5.58 kB (removed) 🏆
dotcom-rendering/dist/3230.legacy.********************.js 0 B -3.3 kB (removed) 🏆
dotcom-rendering/dist/3738.legacy.********************.js 0 B -6.81 kB (removed) 🏆
dotcom-rendering/dist/3738.modern.********************.js 0 B -6.72 kB (removed) 🏆
dotcom-rendering/dist/6087.legacy.********************.js 0 B -6.21 kB (removed) 🏆
dotcom-rendering/dist/6574.modern.********************.js 0 B -7.07 kB (removed) 🏆
dotcom-rendering/dist/684.legacy.********************.js 7.1 kB -463 B (-6%)
dotcom-rendering/dist/684.modern.********************.js 7.1 kB -464 B (-6%)
dotcom-rendering/dist/7731.modern.********************.js 0 B -4.95 kB (removed) 🏆
dotcom-rendering/dist/8571.modern.********************.js 0 B -5.57 kB (removed) 🏆
dotcom-rendering/dist/9562.legacy.********************.js 0 B -6.45 kB (removed) 🏆
dotcom-rendering/dist/Carousel-importable.legacy.********************.js 4.77 kB -119 B (-2%)
dotcom-rendering/dist/Carousel-importable.modern.********************.js 4.59 kB -129 B (-3%)
dotcom-rendering/dist/EditionDropdown-importable.js 0 B -1.54 kB (removed) 🏆
dotcom-rendering/dist/frontend.server.js 426 kB -119 kB (-22%) 🎉
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 4.58 kB -2.02 kB (-31%) 🎉
dotcom-rendering/dist/guardian-braze-components-banner.js 0 B -11.4 kB (removed) 🏆
dotcom-rendering/dist/guardian-braze-components-end-of-article.js 0 B -10.1 kB (removed) 🏆
dotcom-rendering/dist/Liveness-importable.modern.********************.js 6.34 kB +496 B (+8%) 🔍
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 4.85 kB +2.4 kB (+98%) 🆘
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.********************.js 7.42 kB +4.98 kB (+204%) 🆘
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 5.4 kB -1.13 kB (-17%) 👏
dotcom-rendering/dist/readerRevenueDevUtils.js 0 B -2.67 kB (removed) 🏆
dotcom-rendering/dist/SetABTests-importable.legacy.********************.js 5.67 kB +132 B (+2%)
dotcom-rendering/dist/SignInGateMain.js 0 B -3.01 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1124.modern.********************.js 8.35 kB 0 B
dotcom-rendering/dist/1398.legacy.********************.js 5.41 kB 0 B
dotcom-rendering/dist/1398.modern.********************.js 5.3 kB 0 B
dotcom-rendering/dist/1784.legacy.********************.js 3.81 kB 0 B
dotcom-rendering/dist/1931.legacy.********************.js 4.81 kB 0 B
dotcom-rendering/dist/1954.modern.********************.js 6.7 kB 0 B
dotcom-rendering/dist/2054.legacy.********************.js 25.6 kB 0 B
dotcom-rendering/dist/2054.modern.********************.js 24.4 kB 0 B
dotcom-rendering/dist/208.js 1.99 kB 0 B
dotcom-rendering/dist/243.legacy.********************.js 6.16 kB 0 B
dotcom-rendering/dist/243.modern.********************.js 5.96 kB 0 B
dotcom-rendering/dist/2513.legacy.********************.js 2.92 kB 0 B
dotcom-rendering/dist/2513.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/290.modern.********************.js 12.1 kB 0 B
dotcom-rendering/dist/2913.legacy.********************.js 6.77 kB 0 B
dotcom-rendering/dist/3039.legacy.********************.js 2.9 kB 0 B
dotcom-rendering/dist/3039.modern.********************.js 2.89 kB 0 B
dotcom-rendering/dist/3206.legacy.********************.js 5.71 kB 0 B
dotcom-rendering/dist/3428.legacy.********************.js 3.75 kB 0 B
dotcom-rendering/dist/3428.modern.********************.js 3.75 kB 0 B
dotcom-rendering/dist/3490.legacy.********************.js 23.8 kB 0 B
dotcom-rendering/dist/3490.modern.********************.js 23.8 kB 0 B
dotcom-rendering/dist/3559.legacy.********************.js 5.6 kB 0 B
dotcom-rendering/dist/3584.legacy.********************.js 1.8 kB 0 B
dotcom-rendering/dist/3584.modern.********************.js 1.8 kB 0 B
dotcom-rendering/dist/3736.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/385.legacy.********************.js 5.29 kB 0 B
dotcom-rendering/dist/385.modern.********************.js 5.29 kB 0 B
dotcom-rendering/dist/3998.legacy.********************.js 3.61 kB 0 B
dotcom-rendering/dist/4356.modern.********************.js 4.68 kB 0 B
dotcom-rendering/dist/446.modern.********************.js 3.32 kB 0 B
dotcom-rendering/dist/4547.legacy.********************.js 4.62 kB 0 B
dotcom-rendering/dist/4547.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/4621.modern.********************.js 4.42 kB 0 B
dotcom-rendering/dist/463.js 10.5 kB 0 B
dotcom-rendering/dist/4734.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/490.js 2.57 kB 0 B
dotcom-rendering/dist/5.js 1.13 kB 0 B
dotcom-rendering/dist/5001.modern.********************.js 20.6 kB 0 B
dotcom-rendering/dist/5481.legacy.********************.js 3.45 kB 0 B
dotcom-rendering/dist/5481.modern.********************.js 3.43 kB 0 B
dotcom-rendering/dist/5491.legacy.********************.js 3.28 kB 0 B
dotcom-rendering/dist/5578.legacy.********************.js 5.11 kB 0 B
dotcom-rendering/dist/5578.modern.********************.js 5.06 kB 0 B
dotcom-rendering/dist/5814.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/5821.modern.********************.js 5.36 kB 0 B
dotcom-rendering/dist/5888.modern.********************.js 4.61 kB 0 B
dotcom-rendering/dist/5951.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/598.legacy.********************.js 3.69 kB 0 B
dotcom-rendering/dist/598.modern.********************.js 3.38 kB 0 B
dotcom-rendering/dist/6053.legacy.********************.js 4.62 kB 0 B
dotcom-rendering/dist/6053.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/6131.legacy.********************.js 4.3 kB 0 B
dotcom-rendering/dist/6131.modern.********************.js 4.3 kB 0 B
dotcom-rendering/dist/6214.legacy.********************.js 6.45 kB 0 B
dotcom-rendering/dist/6214.modern.********************.js 6.45 kB 0 B
dotcom-rendering/dist/642.js 9 kB 0 B
dotcom-rendering/dist/6544.modern.********************.js 4.51 kB 0 B
dotcom-rendering/dist/6589.legacy.********************.js 7.45 kB 0 B
dotcom-rendering/dist/6881.legacy.********************.js 6.08 kB 0 B
dotcom-rendering/dist/6881.modern.********************.js 5.57 kB 0 B
dotcom-rendering/dist/7185.legacy.********************.js 3.56 kB 0 B
dotcom-rendering/dist/7185.modern.********************.js 3.53 kB 0 B
dotcom-rendering/dist/7198.modern.********************.js 5.47 kB 0 B
dotcom-rendering/dist/7460.modern.********************.js 6.66 kB 0 B
dotcom-rendering/dist/7576.legacy.********************.js 10.1 kB 0 B
dotcom-rendering/dist/7576.modern.********************.js 8.55 kB 0 B
dotcom-rendering/dist/7585.legacy.********************.js 5.32 kB 0 B
dotcom-rendering/dist/7585.modern.********************.js 5.28 kB 0 B
dotcom-rendering/dist/7635.legacy.********************.js 2.78 kB 0 B
dotcom-rendering/dist/7635.modern.********************.js 3.39 kB 0 B
dotcom-rendering/dist/764.legacy.********************.js 6.77 kB 0 B
dotcom-rendering/dist/7716.legacy.********************.js 9.16 kB 0 B
dotcom-rendering/dist/7800.legacy.********************.js 11.3 kB 0 B
dotcom-rendering/dist/7800.modern.********************.js 11.3 kB 0 B
dotcom-rendering/dist/7812.modern.********************.js 4.2 kB 0 B
dotcom-rendering/dist/7829.legacy.********************.js 4.07 kB 0 B
dotcom-rendering/dist/7829.modern.********************.js 3.4 kB 0 B
dotcom-rendering/dist/8227.legacy.********************.js 3.75 kB 0 B
dotcom-rendering/dist/8227.modern.********************.js 3.73 kB 0 B
dotcom-rendering/dist/8255.legacy.********************.js 3.5 kB 0 B
dotcom-rendering/dist/8558.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/8558.modern.********************.js 5.49 kB 0 B
dotcom-rendering/dist/8829.legacy.********************.js 2.98 kB 0 B
dotcom-rendering/dist/8995.modern.********************.js 5.31 kB 0 B
dotcom-rendering/dist/9030.legacy.********************.js 4.01 kB 0 B
dotcom-rendering/dist/9030.modern.********************.js 3.97 kB 0 B
dotcom-rendering/dist/9259.modern.********************.js 5.62 kB 0 B
dotcom-rendering/dist/9393.legacy.********************.js 4.19 kB 0 B
dotcom-rendering/dist/9394.legacy.********************.js 5.04 kB 0 B
dotcom-rendering/dist/9439.legacy.********************.js 4.94 kB 0 B
dotcom-rendering/dist/9614.legacy.********************.js 21.6 kB 0 B
dotcom-rendering/dist/9661.modern.********************.js 3.79 kB 0 B
dotcom-rendering/dist/9751.legacy.********************.js 5.89 kB 0 B
dotcom-rendering/dist/9789.legacy.********************.js 8.48 kB 0 B
dotcom-rendering/dist/9789.modern.********************.js 8.26 kB 0 B
dotcom-rendering/dist/9861.modern.********************.js 6.21 kB 0 B
dotcom-rendering/dist/9909.legacy.********************.js 4.8 kB 0 B
dotcom-rendering/dist/9933.legacy.********************.js 9.14 kB 0 B
dotcom-rendering/dist/9933.modern.********************.js 8.61 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.legacy.********************.js 5.72 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 5.72 kB 0 B
dotcom-rendering/dist/atomIframe.legacy.********************.js 13.5 kB 0 B
dotcom-rendering/dist/atomIframe.modern.********************.js 13.4 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.********************.js 524 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 485 B 0 B
dotcom-rendering/dist/bootCmp.legacy.********************.js 36.9 kB 0 B
dotcom-rendering/dist/bootCmp.modern.********************.js 33.1 kB 0 B
dotcom-rendering/dist/Branding-importable.legacy.********************.js 7.89 kB 0 B
dotcom-rendering/dist/Branding-importable.modern.********************.js 7.88 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.legacy.********************.js 36.9 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.legacy.********************.js 9.11 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 8.1 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.legacy.********************.js 4.94 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 4.65 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 275 B 0 B
dotcom-rendering/dist/CommentCount-importable.legacy.********************.js 2.92 kB 0 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.legacy.********************.js 3.52 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.modern.********************.js 3.49 kB 0 B
dotcom-rendering/dist/CoreVitals-importable.legacy.********************.js 3.62 kB 0 B
dotcom-rendering/dist/CoreVitals-importable.modern.********************.js 3.06 kB 0 B
dotcom-rendering/dist/debug.js 1.75 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.legacy.********************.js 3.87 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 3.61 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.legacy.********************.js 2.25 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 2.21 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 1.59 kB 0 B
dotcom-rendering/dist/dynamicImport.legacy.********************.js 22 kB 0 B
dotcom-rendering/dist/dynamicImport.modern.********************.js 21.6 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.legacy.********************.js 2.36 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.modern.********************.js 4.53 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.********************.js 4.35 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.15 kB 0 B
dotcom-rendering/dist/embedIframe.legacy.********************.js 13.5 kB 0 B
dotcom-rendering/dist/embedIframe.modern.********************.js 13.4 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.********************.js 7.22 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 6.66 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.legacy.********************.js 7.52 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 6.99 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.legacy.********************.js 2.76 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 2.71 kB 0 B
dotcom-rendering/dist/FilterButton-importable.legacy.********************.js 2.94 kB 0 B
dotcom-rendering/dist/FilterButton-importable.modern.********************.js 2.35 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.********************.js 794 B 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 758 B 0 B
dotcom-rendering/dist/FocusStyles-importable.legacy.********************.js 4.73 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 4.67 kB 0 B
dotcom-rendering/dist/ga.legacy.********************.js 20 kB 0 B
dotcom-rendering/dist/ga.modern.********************.js 19.3 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.legacy.********************.js 2.17 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 2.1 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.legacy.********************.js 7.82 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 7.69 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.legacy.********************.js 5.36 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.legacy.********************.js 2.92 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.83 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.legacy.********************.js 11.8 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 11.6 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.********************.js 10.1 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 9.8 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.********************.js 285 B 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 277 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.legacy.********************.js 9.96 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.9 kB +60 B (+1%)
dotcom-rendering/dist/initDiscussion.legacy.********************.js 32.1 kB +12 B (0%)
dotcom-rendering/dist/initDiscussion.modern.********************.js 29 kB +18 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.********************.js 5.84 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 4.75 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.********************.js 4.53 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 4.37 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.legacy.********************.js 7.21 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 6.61 kB 0 B
dotcom-rendering/dist/islands.legacy.********************.js 33 kB 0 B
dotcom-rendering/dist/islands.modern.********************.js 29.5 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.legacy.********************.js 2 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 1.98 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.********************.js 289 B 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 281 B 0 B
dotcom-rendering/dist/LabsHeader-importable.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/LabsHeader-importable.modern.********************.js 5.51 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.********************.js 2.03 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 1.97 kB 0 B
dotcom-rendering/dist/Liveness-importable.legacy.********************.js 7.3 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.********************.js 3.08 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.25 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.legacy.********************.js 4.92 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.3 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.********************.js 5.63 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.legacy.********************.js 12.4 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 12.4 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.legacy.********************.js 7.89 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 7.59 kB 0 B
dotcom-rendering/dist/ophan.legacy.********************.js 24.9 kB 0 B
dotcom-rendering/dist/ophan.modern.********************.js 24.1 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.********************.js 291 B 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 284 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 276 B 0 B
dotcom-rendering/dist/PulsingDot-importable.legacy.********************.js 2.31 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.modern.********************.js 1.7 kB 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.********************.js 283 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 275 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.********************.js 4.64 kB +8 B (0%)
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 4.63 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.legacy.********************.js 3.97 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.64 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.********************.js 5.92 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.56 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.legacy.********************.js 5.7 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/relativeTime.legacy.********************.js 12.5 kB 0 B
dotcom-rendering/dist/relativeTime.modern.********************.js 12.1 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.77 kB +75 B (+1%)
dotcom-rendering/dist/SecureSignupIframe-importable.legacy.********************.js 3.1 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.8 kB 0 B
dotcom-rendering/dist/sentry.legacy.********************.js 791 B 0 B
dotcom-rendering/dist/sentry.modern.********************.js 789 B 0 B
dotcom-rendering/dist/sentryLoader.legacy.********************.js 37.7 kB 0 B
dotcom-rendering/dist/sentryLoader.modern.********************.js 33.6 kB 0 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 5.64 kB 0 B
dotcom-rendering/dist/ShareCount-importable.legacy.********************.js 1.64 kB 0 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 1.62 kB 0 B
dotcom-rendering/dist/shimport.legacy.********************.js 9.53 kB 0 B
dotcom-rendering/dist/shimport.modern.********************.js 6.87 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.legacy.********************.js 1.64 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 1.07 kB 0 B
dotcom-rendering/dist/ShowMore-importable.legacy.********************.js 6.49 kB 0 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 6.4 kB 0 B
dotcom-rendering/dist/SignInGateMain.legacy.********************.js 5.21 kB 0 B
dotcom-rendering/dist/SignInGateMain.modern.********************.js 4.92 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.legacy.********************.js 4.43 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 4.14 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.********************.js 3.03 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 4.56 kB 0 B
dotcom-rendering/dist/Snow-importable.legacy.********************.js 7.18 kB 0 B
dotcom-rendering/dist/Snow-importable.modern.********************.js 6.6 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.********************.js 3 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.********************.js 8.58 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 9.59 kB 0 B
dotcom-rendering/dist/SubNav-importable.legacy.********************.js 3.65 kB 0 B
dotcom-rendering/dist/SubNav-importable.modern.********************.js 3.06 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.legacy.********************.js 5.88 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.51 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 276 B 0 B
dotcom-rendering/dist/TopicFilterBank-importable.legacy.********************.js 1.76 kB 0 B
dotcom-rendering/dist/TopicFilterBank-importable.modern.********************.js 1.7 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.********************.js 1.98 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 1.98 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.legacy.********************.js 826 B 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 833 B 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.********************.js 5.85 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 4.76 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.********************.js 3.09 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.27 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.legacy.********************.js 5.64 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 4.52 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.********************.js 7.05 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 6.76 kB 0 B

compressed-size-action

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR

Lighthouse tested 2 URLs

⚠️ Budget exceeded for 2 of 10 audits.

Report for Article

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category Status Expected Actual
First Contentful Paint 1500 1498
Largest Contentful Paint 3000 2009
Time to Interactive 3500 3173
Cumulative Layout Shift ⚠️ 0.002 0.016917
accessibility 0.97 1.000000

Report for Front

tested url https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint 1500 1420
Largest Contentful Paint 3000 2637
Time to Interactive 3500 2870
Cumulative Layout Shift ⚠️ 0.002 0.014013
accessibility 0.97 0.980000

@mxdvl mxdvl merged commit 18c9b16 into main Dec 19, 2022
@mxdvl mxdvl deleted the dependabot/npm_and_yarn/dotcom-rendering/react-dom-18.2.0 branch December 19, 2022 14:52
@mxdvl
Copy link
Contributor

mxdvl commented Jan 12, 2023

Looking back to this, it may have been a bit premature…

@rschristian
Copy link

Saw the reference in the Preact v11 thread, thought I'd pop in and correct a few things:

the Preact docs only mention v16 and v15

That's largely due to us still missing a few things from v17/v18, such as a streaming renderer (renderToReadableStream()). Most v17/v18 APIs (that we want to support) are supported, but there's a few missing making X (at the moment) not completely compatible in the way we want.

Preact X will bring support to the new v18 hooks, but its release is not even planned yet

Might've misread there, that thread is for the v11 release. X (v10) has been out for a few years now.

Users were asking if the React 18 hooks were going to be added to v11 as, at that time, they hadn't yet landed in v10. However, the intention always was to land them in v10 and indeed we did. Preact has supported those hooks in v10 since mid-June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCR Dependency Dependency for DCR project dotcom-rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants