Passcodes | Update expired functionality for create account/reset password #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…password Previously when the passcode had expired, or had been incorrect multiple times, we'd redirect users to the older `/welcome/expired` page for create account (register), and `/reset-password/expired` for reset password. The problem with these pages is that the copy and UX was more suited to when a link rather than code had expired/invalidated. Instead we now take the same approach as taken on the Sign In page, where we redirect back to the initial page the user took the action on, but show an error with context saying their code had expired, and to receive a new one instead.
coldlink
added
the
passwordless
coldlink
changed the title
4 tasks
coldlink
commented
Feb 6, 2025
Comment on lines
+18
to
+22
| export const PasscodeErrors = { | ||
| PASSCODE_INVALID: 'Incorrect code', | ||
| PASSCODE_EXPIRED: 'Your code has expired', | ||
| } as const; | ||
|
|
There was a problem hiding this comment.
TODO (at some point): refactor the rest of the errors to use as const instead of enums
AshCorr
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously when the passcode had expired, or had been incorrect multiple times, we'd redirect users to the older
/welcome/expiredpage for create account (register), and/reset-password/expiredfor reset password.The problem with these pages is that the copy and UX was more suited to when a link rather than code had expired/invalidated.
Instead we now take the same approach as taken on the Sign In page, where we redirect back to the initial page the user took the action on, but show an error with context saying their code had expired, and to receive a new one instead.
We also add a new errors grouping, specifically for passcodes, called
PasscodeErrors.Screen.Recording.2025-02-06.at.15.55.45.mov
Screen.Recording.2025-02-06.at.15.57.00.mov
Screen.Recording.2025-02-06.at.15.58.46.mov
Screen.Recording.2025-02-06.at.15.59.25.mov
Tested