-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for diacritics in the basic search query and field names in quotes #4398
Conversation
…uotes
Thanks! It makes things better for Unicode. Fixes #1900). The quotes part is better, but not perfect.
No idea how easly/likely would be to fix pt. 1. I can’t see any regressions here and it makes Unicode situation better, so we may decide to follow up in future PRs if the fix isn’t trivial. cc @andrew-nowak |
thanks for approval etc |
Seen on auth, usage, metadata-editor, leases, cropper, media-api (created by @AndyKilmory and merged by @andrew-nowak 8 minutes and 44 seconds ago) Please check your changes! |
Seen on collections, thrall (created by @AndyKilmory and merged by @andrew-nowak 8 minutes and 51 seconds ago) Please check your changes! |
Seen on image-loader (created by @AndyKilmory and merged by @andrew-nowak 8 minutes and 59 seconds ago) Please check your changes! |
Seen on kahuna (created by @AndyKilmory and merged by @andrew-nowak 9 minutes and 8 seconds ago) Please check your changes! |
What does this change?
Currently diacritics are not supported correctly in the search bar - if a user enters diacritics or unicode characters they are removed on page refresh (or entering image view followed by 'back to search'). This makes it hard for users to work with the search bar.
This PR modifies the syntax.js file - specifically the regEx parser used to analyse/breakdown the query content to display correctly as chips etc. - to provide Unicode support
It has also been extended to handle field names that are contained within quotation marks
How should a reviewer test this change?
Ensure that any diacritics entered into search bar are retained on page refresh
Who should look at this?
Tested? Documented?