Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose embed description for editors and CP #302

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

phillipbarron
Copy link
Contributor

What does this change?

Updates the edit form to expose the embed description to allow self service updates for editors and CP

How to test

Run locally and verify that the signUpEmbedDescription field is exposed in the edit form and that it can be edited.

Screenshot 2024-01-17 at 10 24 06

How can we measure success?

The field is present in the form and editable

Have we considered potential risks?

CP and users with editorial access (Newsletters editors at present) will be able to update the embed descriptions and these changes will be seen in embeds (after up to 2 hours because of caching). There is no hard limit on the size of the embed description in the tool. It would be possible to add something absurdly long which would make for an unhappy embed. Access is very limited but we might consider introdicing a sensible validated upper limit in future

@phillipbarron phillipbarron requested a review from a team as a code owner January 17, 2024 10:33
Copy link
Contributor

@Georges-GNM Georges-GNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it locally and confirmed it was now appearing and editable.

Introducing a valid upper limit would make sense, but I'd agree can wait for the moment

@phillipbarron phillipbarron merged commit b3bfefd into main Jan 17, 2024
2 checks passed
@phillipbarron phillipbarron deleted the pb/expose-embed-description branch January 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants