Expose embed description for editors and CP #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the edit form to expose the embed description to allow self service updates for editors and CP
How to test
Run locally and verify that the
signUpEmbedDescription
field is exposed in the edit form and that it can be edited.How can we measure success?
The field is present in the form and editable
Have we considered potential risks?
CP and users with editorial access (Newsletters editors at present) will be able to update the embed descriptions and these changes will be seen in embeds (after up to 2 hours because of caching). There is no hard limit on the size of the embed description in the tool. It would be possible to add something absurdly long which would make for an unhappy embed. Access is very limited but we might consider introdicing a sensible validated upper limit in future