Highlight Restricted live newsletters in detail view #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etters UI to explain that this will prevent it from appearing in MMA or in article promotions appearing. Also, allow editing of this property in the form
dblatcher
approved these changes
Feb 5, 2024
| @@ -76,7 +76,7 @@ export const newsletterDataSchema = z.object({ | |||
| identityName: kebabOrUnderscoreCasedString().describe('identity name'), | |||
| name: nonEmptyString().describe('Name'), | |||
| category: newsletterCategoriesSchema, | |||
| restricted: z.boolean(), | |||
| restricted: z.boolean().describe('Restricted'), | |||
There was a problem hiding this comment.
We could have a longer description for the form field here - maybe something like "Restricted (not shown on frontend)"
Not easy to define since the 'purpose' of restricted it a bit vague.
There was a problem hiding this comment.
Yeah, good shout 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Where a newsletter is live and restricted, show an alert in the newsletters UI to explain that this will prevent it from appearing in MMA or in article promotions appearing. Also, allow editing of this property in the form
How to test
Run locally, set a newsletter to restricted and live, check that the alert appears
Check the the restricted checkbox appears in the edit form
How can we measure success?
By meeting the above conditions
Have we considered potential risks?
Always
Images