Remove ophan status as nothing async happens #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblatcher
approved these changes
Jun 11, 2024
| ophanCampaignCreationStatus: workflowStatusEnumSchema | ||
| .optional() | ||
| .describe( | ||
| 'Ophan campaign creation status', |
There was a problem hiding this comment.
maybe add a comment or update the field description to mark the property as deprecated?
There was a problem hiding this comment.
Yes, great idea. Thanks
phillipbarron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This removes the async status for Ophan as there is no async process for Ophan so this is just noise.
The property is left in the model as an optional so we do not get validation errors on the existing newsletters that have this property. We can, at a later date, run a backfill to remove this property from all the existing live newsletters and then remove the property altogether
This also removed the Ophan element of the launch Wizard. Editorial launch newsletters and don't cre about this. We can edit the Campain code later if required.
How to test
Make sure we can create and launch newsletters and that we can view existing newsletters. (Draft and Live), and that the API response is as expected
How can we measure success?
It still working
Have we considered potential risks?
Should be fine - nothing externally cares about these properties
Images