Merge pull request #1335 from guardian/ts/aa/rename-repocop-github-cr…

…edentials refactor: rename repocop github credentials
guardian · Nov 27, 2024 · 35a9237 · 35a9237
2 parents 9309fac + e38adda
commit 35a9237
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 33 deletions.
diff --git a/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap b/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap
@@ -19443,33 +19443,6 @@ spec:
       },
       "Type": "AWS::SNS::Topic",
     },
-    "branchprotectorgithubappauth4E91892E": {
-      "DeletionPolicy": "Delete",
-      "Properties": {
-        "GenerateSecretString": {},
-        "Name": "/TEST/deploy/service-catalogue/branch-protector-github-app-secret",
-        "Tags": [
-          {
-            "Key": "gu:cdk:version",
-            "Value": "TEST",
-          },
-          {
-            "Key": "gu:repo",
-            "Value": "guardian/service-catalogue",
-          },
-          {
-            "Key": "Stack",
-            "Value": "deploy",
-          },
-          {
-            "Key": "Stage",
-            "Value": "TEST",
-          },
-        ],
-      },
-      "Type": "AWS::SecretsManager::Secret",
-      "UpdateReplacePolicy": "Delete",
-    },
     "cloudbuster8C461939": {
       "DependsOn": [
         "cloudbusterServiceRoleDefaultPolicy173FB27F",
@@ -23251,7 +23224,7 @@ spec:
               "Ref": "dependencygraphintegratorinputtopicTESTDAA73A88",
             },
             "GITHUB_APP_SECRET": {
-              "Ref": "branchprotectorgithubappauth4E91892E",
+              "Ref": "repocopgithubappauthFDE18F33",
             },
             "GITHUB_ORG": "guardian",
             "INTERACTIVES_COUNT": "3",
@@ -23505,7 +23478,7 @@ spec:
               ],
               "Effect": "Allow",
               "Resource": {
-                "Ref": "branchprotectorgithubappauth4E91892E",
+                "Ref": "repocopgithubappauthFDE18F33",
               },
             },
             {
@@ -23551,6 +23524,33 @@ spec:
       },
       "Type": "AWS::IAM::Policy",
     },
+    "repocopgithubappauthFDE18F33": {
+      "DeletionPolicy": "Delete",
+      "Properties": {
+        "GenerateSecretString": {},
+        "Name": "/TEST/deploy/service-catalogue/repocop-github-app-secret",
+        "Tags": [
+          {
+            "Key": "gu:cdk:version",
+            "Value": "TEST",
+          },
+          {
+            "Key": "gu:repo",
+            "Value": "guardian/service-catalogue",
+          },
+          {
+            "Key": "Stack",
+            "Value": "deploy",
+          },
+          {
+            "Key": "Stage",
+            "Value": "TEST",
+          },
+        ],
+      },
+      "Type": "AWS::SecretsManager::Secret",
+      "UpdateReplacePolicy": "Delete",
+    },
     "repocoprepocopcron309MONFRI042F648A2": {
       "Properties": {
         "ScheduleExpression": "cron(30 9 ? * MON-FRI *)",

diff --git a/packages/cdk/lib/service-catalogue.ts b/packages/cdk/lib/service-catalogue.ts
@@ -233,11 +233,11 @@ export class ServiceCatalogue extends GuStack {
 			anghammaradTopicParameter.valueAsString,
 		);
 
-		const githubCredentials = new Secret(
+		const repocopGithubCredentials = new Secret(
 			this,
-			`branch-protector-github-app-auth`,
+			`repocop-github-app-auth`,
 			{
-				secretName: `/${stage}/${stack}/service-catalogue/branch-protector-github-app-secret`,
+				secretName: `/${stage}/${stack}/service-catalogue/repocop-github-app-secret`,
 			},
 		);
 
@@ -258,7 +258,7 @@ export class ServiceCatalogue extends GuStack {
 			vpc,
 			interactiveMonitor.topic,
 			applicationToPostgresSecurityGroup,
-			githubCredentials,
+			repocopGithubCredentials,
 			gitHubOrg,
 		);