ci: Perform basic SQL tests #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in #1066 created a regression, where the `repocop` database user lost access to a view. In this change, we run some SQL in CI in an attempt to catch such regressions earlier.
akash1810
force-pushed
the
aa/ci-repocop-access
branch
from
67aca82 to
759c1c7
Compare
akash1810
commented
Jun 14, 2024
| @@ -130,6 +130,9 @@ jobs: | |||
| - name: perform a DEV database migration | |||
| run: npm -w cli start migrate -- --stage DEV | |||
|
|
|||
| - name: basic database tests | |||
| run: psql -d postgresql://postgres:not_at_all_secret@localhost:5432/postgres -v ON_ERROR_STOP=1 -f sql/ci.sql | |||
There was a problem hiding this comment.
Execute a file, rather than inlining the query, to make it easier to add more tests in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change, and why?
The changes in #1066 created a regression, where the
repocopdatabase user lost access to a view.In this change, we run some SQL in CI in an attempt to catch such regressions earlier.
How has it been verified?
Observe CI. The build log (see below) shows we've switched user, and performed a
SELECT *on the view successfully (the query returns 0 rows as the database is empty).