Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prisma migration for remaining db users #1087

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Jun 14, 2024

What does this change, and why?

Follows #1085, moving the manually applied SQL scripts to create the dataaudit, and github_actions_usage users, and apply permissions, to a Prisma migration, so that it gets automatically applied.

How has it been verified?

See CI.

@akash1810 akash1810 force-pushed the aa/migrate-db-users branch 2 times, most recently from 6d3d13d to bc4ab73 Compare June 14, 2024 13:26
@akash1810 akash1810 changed the title feat(dataaudit): Prisma migration for dataaudit db user feat: Prisma migration for remaining db users Jun 14, 2024
@akash1810 akash1810 marked this pull request as ready for review June 14, 2024 13:45
@akash1810 akash1810 requested review from a team as code owners June 14, 2024 13:45
Base automatically changed from aa/ci-repocop-access to main June 17, 2024 08:01
@akash1810 akash1810 force-pushed the aa/migrate-db-users branch 2 times, most recently from 3c86db2 to faf14f9 Compare June 18, 2024 08:33
Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👌

Moves the manually applied SQL script to create the `dataaudit` user,
and apply permissions, to a Prisma migration, so that it gets automatically applied.
Moves the manually applied SQL script to create the `github_actions_usage` user,
and apply permissions, to a Prisma migration, so that it gets automatically applied.
@akash1810 akash1810 force-pushed the aa/migrate-db-users branch from faf14f9 to b5a266a Compare June 18, 2024 09:32
@akash1810 akash1810 enabled auto-merge June 18, 2024 09:32
@akash1810 akash1810 merged commit 25add47 into main Jun 18, 2024
4 checks passed
@akash1810 akash1810 deleted the aa/migrate-db-users branch June 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants