Feat: allow for exemption of repos from dependency graph integrator #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjsilver
force-pushed
the
ts/custom-props-dep-graph-ignore
branch
from
155b68a to
8b71e13
Compare
tjsilver
force-pushed
the
ts/custom-props-dep-graph-ignore
branch
from
8b71e13 to
07ce2f6
Compare
tjsilver
force-pushed
the
ts/custom-props-dep-graph-ignore
branch
from
07ce2f6 to
92dc4d4
Compare
| @@ -119,10 +121,27 @@ async function sendOneRepoToDepGraphIntegrator( | |||
| } | |||
| } | |||
|
|
|||
| export function getReposWithoutWorkflows( | |||
| export function repoIsExempted( | |||
There was a problem hiding this comment.
Should the language be passed in here? ie. 'Scala' or 'Kotlin'
Comment on lines
+128
to
+129
| const repoIsExcepted = exceptedCustomProperties.find( | ||
| (property) => repo.id === property.repository_id, |
There was a problem hiding this comment.
Should the value of the property be compared to the language here? eg. is it Scala
| value: 'Scala', | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps we need another test for Kotlin and one for an entirely irrelevant language to prove that we distinguish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
github_repositories_custom_propertiestable.gu_dependency_graph_integrator_ignoreand excludes any repos that have this property from dependency graph integration.Why?
There is at least one repo that we know of that contains a script written in Scala file but that doesn't use sbt. As there are no dependencies for Scala in the repo, it doesn't need to have the sbt dependency submission workflow. Currently, the dependency graph integrator will identify this repo as requiring a workflow, and continue to raise a PR against it if the existing PR is closed or if the workflow is not merged in.
How has it been verified?
github_repositories_custom_properties.