Add Github team slug to view_repo_ownership
#831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislomaxjones
changed the title
view_repo_ownership
NovemberTang
approved these changes
Mar 4, 2024
chrislomaxjones
force-pushed
the
nt-clj/add-slug-to-view-repo-ownership
branch
from
9fd9d53 to
f9c9b73
Compare
chrislomaxjones
force-pushed
the
nt-clj/add-slug-to-view-repo-ownership
branch
from
f9c9b73 to
660996a
Compare
akash1810
reviewed
Mar 5, 2024
- Add team slug - Add repo short name Co-authored-by: Natasha <[email protected]>
These changes were automatically created by running ```npm -w cli start migrate -- --stage DEV` Co-authored-by: Natasha <[email protected]>
Co-authored-by: Natasha <[email protected]>
Co-authored-by: Natasha <[email protected]> Co-authored-by: Akash Askoolum <[email protected]> Co-authored-by: TJ Silver <[email protected]>
Co-authored-by: Natasha <[email protected]> Co-authored-by: Akash Askoolum <[email protected]> Co-authored-by: TJ Silver <[email protected]>
NovemberTang
force-pushed
the
nt-clj/add-slug-to-view-repo-ownership
branch
from
660996a to
1262d3c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a new Prisma migration that drops and recreates the
view_repo_ownershipview.The migration contains some breaking schema changes:
github_team_slug.short_repo_name.repo_name.full_namecolumn tofull_repo_name.As some of these changes are breaking, this required changes in the Recocop application code, which are included as part of this PR.
Note
Applying the migration without deploying the new Repocop application will break Repocop (as field names have changed). This shouldn't be a problem in reality, as Repocop runs on a schedule such that we should be able to migrate the database and deploy the new application between invocations.
Why?
Making the team slug available in this view should ease sending notifications to Anghammarad, as we previously had to join this data with another table to retrieve team slugs.
How has it been verified?
The dev migration was successfully applied locally. On approval, we'll also test this migration on CODE.