Country wide targetting #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAKSHMIRPILLAI
force-pushed
the
lp-add-target-by-country
branch
from
1a10039 to
e736633
Compare
4 tasks
…hema and update the sidebar filter
Gutter tests
…or existing tests
… dropdown for the Apple News Epics
LAKSHMIRPILLAI
force-pushed
the
lp-add-target-by-country
branch
from
75ee851 to
060d9c5
Compare
tomrf1
reviewed
Feb 6, 2025
public/src/utils/models.tsx
Outdated
| @@ -287,6 +287,7 @@ export const countries: CommonStringObject = { | |||
| ZW: 'Zimbabwe', | |||
| }; | |||
|
|
|||
| export const countryNames = Object.entries(countries).map(_ => [_[0], _[1]]); | |||
There was a problem hiding this comment.
This is quite hard to follow - how about removing this and instead in MultiSelectCountryEditor.tsx define:
const options: Option[] = Object.entries(countries).map(([value, label]) => ({ value, label }));
tomrf1
reviewed
Feb 6, 2025
| @@ -135,6 +136,35 @@ const BannerTestEditor: React.FC<ValidatedTestEditorProps<BannerTest>> = ({ | |||
| updateTest({ ...test, locations: updatedRegions }); | |||
| }; | |||
|
|
|||
| function concatUniqueLocations(countryGroups: Region[], locations: Region[]) { | |||
There was a problem hiding this comment.
I don't think this is necessary if we initialise regionTargeting with the country groups from locations.
Here's a proposal for doing this which I think simplifies things a lot - what do you think? -
#682
There was a problem hiding this comment.
This is great, I am happy to merge this
simplify locations deprecation
tomrf1
reviewed
Feb 6, 2025
| @@ -24,11 +25,16 @@ const useStyles = makeStyles(({ spacing, palette }: Theme) => ({ | |||
| color: palette.grey[900], | |||
| fontWeight: 500, | |||
| }, | |||
| container1: { | |||
There was a problem hiding this comment.
could this name be more descriptive?
|
Seen on PROD (merged by @LAKSHMIRPILLAI 7 minutes and 28 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with: @charleycampbell
What does this change?
Country wide targeting in RRCP
Trello card
This PR is to enable country wide targeting along with Region wide targeting in RRCP under the 'Target Audience' section .The countries to be targeted can be selected from the dropdown list .The supporting changes in support-dotcom-component are in the SDC PR
How to test
Test in CODE Detailed testing doc is added [here]
Tests for RRCP changes
Similar tests were done for Banners, Headers, Liveblog Epics, Apple News Epics and AMP Epics
Images