Basic module tests #505
Merged
Basic module tests #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompretty
reviewed
Aug 16, 2021
package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "build": "yarn workspaces run build", | |||
| "presetup": "yarn clean", | |||
| "setup": "tsc --build", | |||
| "test": "export stage=DEV; yarn server test && yarn shared test", | |||
| "test": "export stage=DEV; yarn server test && yarn shared test && yarn modules test", | |||
There was a problem hiding this comment.
Now that we're running tests in all of the workspaces, we can do
"test": "export stage=DEV; yarn workspaces run test",
tompretty
reviewed
Aug 16, 2021
Comment on lines
-4
to
+5
| { "runtime": "automatic", "importSource": "@emotion/react" } | ||
| ], | ||
| { "runtime": "automatic", "importSource": "@emotion/react" } | ||
| ], |
There was a problem hiding this comment.
looks like this is just a formatting change?
tompretty
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR: #384 by @tompretty
But I started a new branch because too much has changed since the refactor.
This PR includes a very basic rendering test for the epic.
We can start adding more tests soon