feat: DigitalSubscription subscribe CTA initial re-route

guardian · Jan 30, 2025 · 0450b01 · 0450b01
1 parent 181564f
commit 0450b01
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/support-frontend/assets/helpers/urls/routes.ts b/support-frontend/assets/helpers/urls/routes.ts
@@ -1,4 +1,5 @@
 // ----- Routes ----- //
+import type { BillingPeriod } from 'helpers/productPrice/billingPeriods';
 import type {
 	FulfilmentOptions,
 	PaperFulfilmentOptions,
@@ -29,8 +30,8 @@ const routes = {
 	payPalRestReturnURL: '/paypal/rest/return',
 	subscriptionCreate: '/subscribe/create',
 	subscriptionsLanding: '/subscribe',
+	checkout: '/checkout',
 	digitalSubscriptionLanding: '/subscribe/digitaledition',
-	digitalSubscriptionLandingGift: '/subscribe/digital/gift',
 	paperSubscriptionLanding: '/subscribe/paper',
 	paperSubscriptionProductChoices: '/subscribe/paper#HomeDelivery',
 	paperSubscriptionDeliveryProductChoices:
@@ -83,13 +84,14 @@ function paperSubsUrl(
 
 function digitalSubscriptionLanding(
 	countryGroupId: CountryGroupId,
-	gift: boolean,
+	billingPeriod?: BillingPeriod,
 ) {
-	return `${getOrigin()}/${countryPath(countryGroupId)}${
-		gift
-			? routes.digitalSubscriptionLandingGift
-			: routes.digitalSubscriptionLanding
-	}`;
+	const routeDigitalSubscription = billingPeriod
+		? routes.checkout
+		: routes.digitalSubscriptionLanding;
+	return `${getOrigin()}/${countryPath(
+		countryGroupId,
+	)}${routeDigitalSubscription}`;
 }
 
 function guardianWeeklyLanding(countryGroupId: CountryGroupId, gift: boolean) {

diff --git a/support-frontend/assets/pages/promotion-terms/DigitalPackTerms.tsx b/support-frontend/assets/pages/promotion-terms/DigitalPackTerms.tsx
@@ -22,7 +22,7 @@ export default function DigitalPackTerms(props: PropTypes) {
 		'By entering the promotion you are accepting these terms and conditions.',
 		<div>
 			To enter the promotion, you must: (i) either go to{' '}
-			<a href={digitalSubscriptionLanding(props.countryGroupId, false)}>
+			<a href={digitalSubscriptionLanding(props.countryGroupId)}>
 				support.theguardian.com
 			</a>{' '}
 			or call +44 (0) 330 333 6767 and quote promotion code {props.promoCode}{' '}

diff --git a/support-frontend/assets/pages/subscriptions-landing/copy/subscriptionCopy.tsx b/support-frontend/assets/pages/subscriptions-landing/copy/subscriptionCopy.tsx
@@ -73,7 +73,7 @@ const digital = (
 	buttons: [
 		{
 			ctaButtonText: 'Find out more',
-			link: digitalSubscriptionLanding(countryGroupId, false),
+			link: digitalSubscriptionLanding(countryGroupId),
 			analyticsTracking: sendTrackingEventsOnClick({
 				id: 'digipack_cta',
 				product: 'DigitalPack',