Skip to content

Commit

Permalink
Merge pull request #119 from guardian/lp-update-node18
Browse files Browse the repository at this point in the history
Update the node runtime from v14 to v18
  • Loading branch information
LAKSHMIRPILLAI committed Aug 11, 2023
2 parents 9641c9f + f003de8 commit 359688c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.15.0
18
20 changes: 10 additions & 10 deletions cdk/lib/__snapshots__/support-reminders.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1372,7 +1372,7 @@ exports[`The SupportReminders stack matches the snapshot 1`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -1602,7 +1602,7 @@ exports[`The SupportReminders stack matches the snapshot 1`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -1832,7 +1832,7 @@ exports[`The SupportReminders stack matches the snapshot 1`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -2207,7 +2207,7 @@ exports[`The SupportReminders stack matches the snapshot 1`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -2437,7 +2437,7 @@ exports[`The SupportReminders stack matches the snapshot 1`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -4158,7 +4158,7 @@ exports[`The SupportReminders stack matches the snapshot 2`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -4388,7 +4388,7 @@ exports[`The SupportReminders stack matches the snapshot 2`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -4618,7 +4618,7 @@ exports[`The SupportReminders stack matches the snapshot 2`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -4993,7 +4993,7 @@ exports[`The SupportReminders stack matches the snapshot 2`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down Expand Up @@ -5223,7 +5223,7 @@ exports[`The SupportReminders stack matches the snapshot 2`] = `
"Arn",
],
},
"Runtime": "nodejs14.x",
"Runtime": "nodejs18.x",
"Tags": [
{
"Key": "App",
Expand Down
2 changes: 1 addition & 1 deletion cdk/lib/support-reminders.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class SupportReminders extends GuStack {
// ---- Miscellaneous constants ---- //
const app = "support-reminders";
const vpc = GuVpc.fromIdParameter(this, "vpc");
const runtime = Runtime.NODEJS_14_X;
const runtime = Runtime.NODEJS_18_X;
const fileName = "support-reminders.zip";
const environment = {
"Bucket": props.datalakeBucket,
Expand Down

0 comments on commit 359688c

Please sign in to comment.