Add optional reminderCreatedAt field #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompretty
force-pushed
the
tp-add-reminder-created-at
branch
from
394e724
to
1090cc0
Compare
tompretty
force-pushed
the
tp-add-reminder-created-at
branch
from
1090cc0
to
c78be59
Compare
tompretty
changed the title
reminderCreatedAt field
tomrf1
reviewed
Feb 15, 2021
| export interface OneOffSignupRequest extends BaseSignupRequest { | ||
| reminderPeriod: ReminderPeriod; | ||
| } | ||
| // typecheck.macro doesn't support extends |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adding this field will allow us to backfill current pending reminders created on the old architecture.
Additionally, I've refactored
OneOffSignupRequestandRecurringSignupRequestto use a type union instead of extending a base type. This is becausetypecheck.macrodoesn't support extending types (it wasn't actually validating any of the fields defined in the base type) (vedantroy/typecheck.macro#2)