Bring sass under webpack, move package.json to project root. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! great stuff 👍 |
|
@steppenwells I'll merge this, but as noted will allow you to delete node modules in your public folder (and greatly speed up sbt startup speeds!) |
clloyd
pushed a commit
that referenced
this pull request
Nov 9, 2015
Bring sass under webpack, move package.json to project root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sass is now compiled by webpack, giving us hot-reloading in client-dev mode.
This also moves the package.json (and node_modules) out of /public and into the root, this reduces the time taken to refresh a page after an asset file change from around 5 seconds to 1 second, and builds from around 11 mins to 5 mins.
!!!
After merge you'll need to delete the node_modules folder inside your public directory and re-run
./scripts/setup.sh