Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to target v2 Terminal.Gui #6

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Update to target v2 Terminal.Gui #6

merged 4 commits into from
Sep 19, 2024

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Sep 19, 2024

Fixes gui-cs/Terminal.Gui#3746

  • Now targets dotnet 8
  • Now targets v2 develop package that matches TGD compatibility (2203)

I looked into flexible targeting like v1 i.e.
<PackageReference Include="Terminal.Gui" Version="2.0.0-*"/>

But there were 2 problems

  • This seemed to update to Terminal.Gui/2.0.0-v2-release.1809 for some reason - I guess because naming convention has changed in releases
  • If we are flexible targetting we may end up with a broken template because of backwards compatibility breaking changes in alpha
  • Its nice to target the same version as TGD for consistency and stability

@tznind tznind requested a review from tig September 19, 2024 07:40
templates/basic/MyView.cs Outdated Show resolved Hide resolved
@tznind tznind merged commit 377d63f into main Sep 19, 2024
1 check passed
@tznind tznind deleted the v2 branch September 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal Gui Templates still using v1
2 participants