Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2944. Makes ColorScheme explicitly readonly, removes Colors.Base, etc..., Fixes intermittent TreeView unit test failures #3175

Merged
merged 16 commits into from
Jan 16, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Jan 14, 2024

Fixes

Third (or fourth?) try is a charm???

Proposed Changes/Todos

  • Debug ColorScheme as it seems the likely culprit.
  • Moved ColorScheme and Color to ColorSchemes.cs
  • Beefed up unit tests
  • Fixed likely TreeView test but: FakeDriver was not setting PlatformColor to -1 in Make
  • Made Color and ColorScheme more robust by
  • Updated API docs

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #2944. intermittent TreeView unit test failures Fixes #2944. Makes ColorScheme explicitly readonly, removes Colors.Base, etc..., Fixes intermittent TreeView unit test failures Jan 15, 2024
@tig tig requested review from tznind and BDisp January 15, 2024 04:38
@tig tig merged commit 2c725b8 into gui-cs:v2_develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants