Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2800 - Color picker (supporting hsl, hsv and rgb) #3604

Merged
merged 99 commits into from
Aug 22, 2024
Merged

Fixes #2800 - Color picker (supporting hsl, hsv and rgb) #3604

merged 99 commits into from
Aug 22, 2024

Commits on Jul 11, 2024

  1. Readonly HSL view

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b96836c View commit details
    Browse the repository at this point in the history

  2. Make it possible to move between bars by moving to subview

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    266f698 View commit details
    Browse the repository at this point in the history

  3. Basically working and with mouse support

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    013252e View commit details
    Browse the repository at this point in the history

  4. Fix HSL to work properly with double values instead of color matching

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    894d4df View commit details
    Browse the repository at this point in the history

  5. Fix Value on ColorPicker to match HSL values

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0ea13cf View commit details
    Browse the repository at this point in the history

  6. Fix color spectrum

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    602fa21 View commit details
    Browse the repository at this point in the history

  7. Add Swatch and better sync with text box

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    eb569f4 View commit details
    Browse the repository at this point in the history

  8. Work on jitter

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c02cb8c View commit details
    Browse the repository at this point in the history

  9. ColorPicker HSL working

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2f844fb View commit details
    Browse the repository at this point in the history

  10. More keybindings

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d2deb14 View commit details
    Browse the repository at this point in the history

  11. Add ColorModel

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    257d97c View commit details
    Browse the repository at this point in the history

  12. Support both HSL and HSV

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    49cebf0 View commit details
    Browse the repository at this point in the history

  13. Add RGB

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d3b09f5 View commit details
    Browse the repository at this point in the history

  14. Better mouse handling

    @tznind
    tznind committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    97e4a6e View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    11a8f0d View commit details
    Browse the repository at this point in the history

  2. WIP: AttributeView and integrate into LineDrawing 

    (does not currently work properly)
    @tznind
    tznind committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    82aa2d2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f3a90ba View commit details
    Browse the repository at this point in the history

  4. Fix color picking

    @tznind
    tznind committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    cc4feed View commit details
    Browse the repository at this point in the history

  5. Add concept of an ITool

    @tznind
    tznind committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    29a13ca View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Add ColorPickerStyle

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0558b2d View commit details
    Browse the repository at this point in the history

  2. Fix selected cell rendering

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    4241fb0 View commit details
    Browse the repository at this point in the history

  3. Add first test for ColorPicker2

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    206a025 View commit details
    Browse the repository at this point in the history

  4. Add more RGB tests

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    14d9b3d View commit details
    Browse the repository at this point in the history

  5. Improve ColorPicker2 setup process

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    df9fb5a View commit details
    Browse the repository at this point in the history

  6. Tests and fixes for keyboard changing value R

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    e73408c View commit details
    Browse the repository at this point in the history

  7. Fix margin on bars when no textfields

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    f9fac50 View commit details
    Browse the repository at this point in the history

  8. Add mouse test

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    7fecfea View commit details
    Browse the repository at this point in the history

  9. Add tests for with text field

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    7fbc5cb View commit details
    Browse the repository at this point in the history

  10. Add more tests and fix bug sync component text field change with hex … 

    …text field

(WIP - failing tests)
    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    32c4357 View commit details
    Browse the repository at this point in the history

  11. Fix tests and fix clicking in a bar label area possibly not selecting

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8a1abfa View commit details
    Browse the repository at this point in the history

  12. Move AttributeView to LineDrawing and adjust to have a 'transparent p… 

    …attern' too
    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    e13389d View commit details
    Browse the repository at this point in the history

  13. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8d8de6d View commit details
    Browse the repository at this point in the history

  14. Render triangle in dark gray if background is black

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    c718c15 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    68fe0d6 View commit details
    Browse the repository at this point in the history

  16. Add ColorChanged event

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    be83712 View commit details
    Browse the repository at this point in the history

  17. Resharper Cleanup

    @tznind
    tznind committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    034cbc1 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    011f2a6 View commit details
    Browse the repository at this point in the history

  2. Xml comments and public/private adjustments

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    ce63697 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    bd1a00e View commit details
    Browse the repository at this point in the history

  4. Explore replacing diagram test with fragile Subview diving

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    d4697bd View commit details
    Browse the repository at this point in the history

  5. Migrate ColorPicker_DefaultBoot to sub asserts

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    7ad915e View commit details
    Browse the repository at this point in the history

  6. Port other tests

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    5c2bb8a View commit details
    Browse the repository at this point in the history

  7. Replace ColorPicker with new view

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    046c2fd View commit details
    Browse the repository at this point in the history

  8. Fix ColorPicker size to match scenarios size assumptions

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    0c099e0 View commit details
    Browse the repository at this point in the history

  9. Split to separate files and ignore invalid test for ColorPicker

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    4dc4862 View commit details
    Browse the repository at this point in the history

  10. Ignore also in mouse version of AllViews_Enter_Leave_Events

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    04645dc View commit details
    Browse the repository at this point in the history

  11. Remove bool _updating from ColorPicker 

    Now instead we are more selective about what we update when and do so deterministically
    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    d6eb6c3 View commit details
    Browse the repository at this point in the history

  12. Typo fix

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    6eecec3 View commit details
    Browse the repository at this point in the history

  13. Fix ReSharper bad renames in comments for "Value"

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    b4e32fd View commit details
    Browse the repository at this point in the history

  14. Refactor to single implementation of 'prompt for color' logic 

    - Now called PromptForColor
- Shared by LineDrawing and ProgressBarStyles scenarios
    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e3e90ef View commit details
    Browse the repository at this point in the history

  15. Sum runes instead of Length

    @tznind
    tznind committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f9f62a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Hide ColorBar and SetValueWithoutRaisingEvent from public API

    @tznind
    tznind committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    21897b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    4db6f40 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    d99996a View commit details
    Browse the repository at this point in the history

  2. Move ColorEventArgs to Drawing folder

    @tznind
    tznind committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    9c58889 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    e462ece View commit details
    Browse the repository at this point in the history

  4. Move ColorModel to Drawing folder

    @tznind
    tznind committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6f81f3e View commit details
    Browse the repository at this point in the history

  5. First try at Dim.Auto for ColorPicker

    @tznind
    tznind committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    769c37e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    182d631 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Remove explicit width/height setting in most scenarios

    @tznind
    tznind committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    113d513 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    fa9ff49 View commit details
    Browse the repository at this point in the history

  3. Remove explicit heights

    @tznind
    tznind committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    93f0efc View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    33422b4 View commit details
    Browse the repository at this point in the history

  2. Fixed build/test issues. 

    Illustrated test best practice.
    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    6b5e3a0 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #166 from tig/tznind-color-picker-hsv 

    Fixed build/test issues & Illustrated test best practices
    @tznind
    tznind committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    885cfa8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. WIP: Start working on test changes and add new options to ColorPicker… 

    …s scenario (Color Model and show textfields).
    @tznind
    tznind committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9a5d713 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    39efad8 View commit details
    Browse the repository at this point in the history

  3. Fix for R indicator arrow sometimes 'falling off' the drawn area.

    @tznind
    tznind committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    337390a View commit details
    Browse the repository at this point in the history

  4. Add nullable enable

    @tznind
    tznind committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3a1203d View commit details
    Browse the repository at this point in the history

  5. Test fixes and refactor for avoiding Begin

    @tznind
    tznind committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6e2f612 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    4be9476 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2519eda View commit details
    Browse the repository at this point in the history

  2. Make ColorEventArgs inherit from EventArgs<Color>

    @tznind
    tznind committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ea61495 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    045c7a2 View commit details
    Browse the repository at this point in the history

  4. Fix Dispose not being called on bars when switching color models

    @tznind
    tznind committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e371e99 View commit details
    Browse the repository at this point in the history

  5. Remove 'oldColor' from test now it is not supported

    @tznind
    tznind committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b41a566 View commit details
    Browse the repository at this point in the history

  6. Add initial stab at ColorPickerStyle.ShowName

    @tznind
    tznind committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2efd89f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ceeb54d View commit details
    Browse the repository at this point in the history

  2. Use AppendAutocomplete for color names

    @tznind
    tznind committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7bcaac3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4f41730 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b4b37ef View commit details
    Browse the repository at this point in the history

  5. Implemented resoruce based colorname resolver

    @tig
    tig committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2df0981 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Merge pull request #167 from tig/tznind-color-picker-hsv 

    Implemented resource based colorname resolver
    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3978a2b View commit details
    Browse the repository at this point in the history

  2. Update GetTextField to support getting the color names field 

    Change style setting to ShowColorName
    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a97096a View commit details
    Browse the repository at this point in the history

  3. Color name updates when navigating away from the named color

    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    9e79569 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3312cbc View commit details
    Browse the repository at this point in the history

  5. Restore old color picker as ColorPicker16

    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    d1862d9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6c17a6a View commit details
    Browse the repository at this point in the history

  7. Add test that shows 'Save as' is currently considered a named color ><

    @tznind
    tznind committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0bbe95e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Fix GetW3CColorNames

    @tznind
    tznind committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    0df0ffa View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bdaa262 View commit details
    Browse the repository at this point in the history

  2. Removed dupe colors

    @tig
    tig committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    77bd8ac View commit details
    Browse the repository at this point in the history

  3. Merged correctly. Code Cleanup

    @tig
    tig committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    98d5d7c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #168 from tig/tznind-color-picker-hsv 

    Removed dupe colors
    @tznind
    tznind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    37dc439 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'v2_develop' into color-picker-hsv

    @tig
    tig committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b36a9ba View commit details
    Browse the repository at this point in the history

  6. Revert to old color pickers

    @tznind
    tznind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a83ea4b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'color-picker-hsv' of https://github.com/tznind/gui.cs i… 

    …nto color-picker-hsv
    @tznind
    tznind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0d91d68 View commit details
    Browse the repository at this point in the history

  8. Nullability question marks for everyone!

    @tznind
    tznind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    461168b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'v2_develop' into color-picker-hsv

    @tznind
    tznind committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e275eb6 View commit details
    Browse the repository at this point in the history