Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3771. TextView doesn't consider no-printable rune in draw and cursor position. #3772

Open
wants to merge 18 commits into
base: v2_develop
Choose a base branch
from
Open

Fixes #3771. TextView doesn't consider no-printable rune in draw and cursor position. #3772

wants to merge 18 commits into from
+848 −554

Commits on Oct 1, 2024

  1. Fixes gui-cs#3771. TextView doesn't consider no-printable rune in dra… 

    …w and cursor position.
    @BDisp
    BDisp committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6a6c210 View commit details
    Browse the repository at this point in the history

  2. Add unit test which already works in TextField.

    @BDisp
    BDisp committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7bf6aaa View commit details
    Browse the repository at this point in the history

  3. Replace Frame to Viewport in TextField.

    @BDisp
    BDisp committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e4d30a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fixes gui-cs#3774. TextModel.ToRuneCellList is internal and is better… 

    … move it to the public RuneCell class.
    @BDisp
    BDisp committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    026a20e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v2_develop' into v2_3771_textview-no-printable-rune-fix

    @BDisp
    BDisp authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2292a86 View commit details
    Browse the repository at this point in the history

  3. Trying fix unit test error.

    @BDisp
    BDisp committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    153a9f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Move necessary methods to the RuneCell class per gui-cs#3774 (comment).

    @BDisp
    BDisp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    29799f4 View commit details
    Browse the repository at this point in the history

  2. Fix LineDrawing PromptForColor to support 16 colors and true color.

    @BDisp
    BDisp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5a1a0ce View commit details
    Browse the repository at this point in the history

  3. Add support for colored runes in the Editor scenario.

    @BDisp
    BDisp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bb5af01 View commit details
    Browse the repository at this point in the history

  4. Add borders to the 16 colors.

    @BDisp
    BDisp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bd42a48 View commit details
    Browse the repository at this point in the history

  5. Only consider SelectionStartRow and SelectionStartColumn when Selecte… 

    …dLength is grater than 0.
    @BDisp
    BDisp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d3be2ac View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fix ApplyRuneCellAttribute method.

    @BDisp
    BDisp committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a4f2352 View commit details
    Browse the repository at this point in the history

  2. Fix width for 16 colors.

    @BDisp
    BDisp committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    439bddf View commit details
    Browse the repository at this point in the history

  3. Fix start/end row and cols.

    @BDisp
    BDisp committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    903827a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Change all RuneCell to Cell and move methods to the Cell record struct.

    @BDisp
    BDisp committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ccf2daa View commit details
    Browse the repository at this point in the history

  2. Using the attribute at the cursor position on paste.

    @BDisp
    BDisp committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    f93b475 View commit details
    Browse the repository at this point in the history

  3. Fix unit test.

    @BDisp
    BDisp committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c54041e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Add feature to copy, cut and paste with the cells attributes.

    @BDisp
    BDisp committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    6a0aa9a View commit details
    Browse the repository at this point in the history