add dependabot and test automation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmahyde
approved these changes
Apr 22, 2024
emmahyde
reviewed
Apr 22, 2024
| build: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
why not fail-fast? (just curious, I don't know much about minitest)
There was a problem hiding this comment.
https://www.edwardthomson.com/blog/github_actions_6_fail_fast_matrix_workflows.html
if we test more than one ruby, we want them all to finish so we can see results (vs stop after first one fails) as they run in parallel
There was a problem hiding this comment.
ooooh, very cool! TIL GHA matrices.
I interpreted "fail-fast" as a configuration for each test, where if 1 assertion fails, it either does or does not test the rest of the assertions. Thanks for the clarification!
mnelson
added a commit
that referenced
this pull request
Apr 22, 2024
* refactor, remove unnecessary behaviors * hook up to a db * clean up schema, simplify * continue refactor, thinning out schema * integrate with minitest * release beta * more documentaiton and cleanup * thread safety, move to configuration class * move things around a bit more * make files_changed? public * bundle update * more documentation, single top level variables * allow strict_dependencies to be an option * do not blow up if fixtury overrides test method * bump to beta7 * add dependabot and test automation (#19) --------- Co-authored-by: Aaron Averbuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.