Add support for YouTube Music.

[pedromakaveli]

added new support for youtube music

[guihkx]

Thanks for the contribution! 🏆

Based on an initial impression, the logic looks good overall. But there are minor issues that'd I like you to fix before I can finally test and merge this, though. :)

Most issues are related to code formatting, so if you want to easily fix those, please check out the "Contributing" section:

https://github.com/guihkx/spotishush#contributing

Also, can you please rename the pull request and mention that you're adding support for YouTube Music? Thanks!

[guihkx]

A minor (yet annoying) issue I found with the current implementation is that if you're unlucky enough to get an ad the first time you play a song, the extension will not mute it fast enough:

Video_2023-09-27_01-43-21_edit.mp4

So, I'd like to find a faster way to handle this specific scenario before I can merge this.

Other than that, I'd say the detection mechanism seems to work pretty reliably!

[gdelcroix]

i think the way to handle this more quickly would be to mute YoutubeMusic by default immediately when starting the monitoring, and unmute if the first video isn't an ad.

[guihkx]

Hmm, I'm not sure if that would be preferable. In a scenario where we don't get an ad on the first music video, then the music itself would be muted for a second, which IMO would be equally annoying.

I haven't looked at this in a while too, (I don't really use YouTube Music), but perhaps the delay in muting/unmuting is gone now. Or the ad detection mechanism is simply broken... Either way, I have to revisit this.