WIP Mixiskra #12
Open
WIP Mixiskra #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrehault
requested changes
Apr 14, 2020
| } | ||
|
|
||
| export interface AvialiableRole { |
| } | ||
|
|
||
| export interface Entrie { |
| @@ -140,6 +140,7 @@ export interface Resource extends BaseItem { | |||
| '@name': string; | |||
| '@type': string; | |||
| '@uid': string; | |||
| UID: string; | |||
There was a problem hiding this comment.
Guillotina resources do not have a UID attribute
There was a problem hiding this comment.
Plone resources does not have @uid :')
There was a problem hiding this comment.
ok, so 2 options:
- Either me make both of them optional:
@uid'?: string;
UID?: string;
and in all our code, we will have to check which value exists.
- Either in the resource service, in
get(and any method returning a resource) we normalize the data to renameUIDinto@uid. It could be done by a function we provide in the main app module, and we would provide it only when using Plone as backend.
I like the 2nd option :)
There was a problem hiding this comment.
I like 2nd Option also !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.