Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseImage #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

edenhaus
Copy link

@edenhaus edenhaus commented Jul 13, 2023

Changes:

  • refactor BaseImage so that it is passed a ContainerConfiguration object with the hole config instead of having all config of all containers in the dict in images
  • add type hits to BaseImage
  • add mosquitto with tests
  • add devcontainer
  • add pre-commit
  • upgrade code to python3.8 as python 3.6,3.7 are EOL
  • rename BaseImage to BaseContainer as they are actually container, we do only run the images

As there are some breaking changes we need to set the version to 2.0.0

What are you thinking?

edenhaus added 3 commits July 13, 2023 14:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kizill
Copy link

kizill commented Aug 30, 2023

@vangheem - is it possible to review this PR? Seems like a very useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants