Don't override profiling settings injected by environment variables #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guizmaii hopefully this is straightforward, let me know if you have any questions. |
guizmaii
approved these changes
Nov 17, 2024
guizmaii
added a commit
that referenced
this pull request
Nov 17, 2024
…LING_DIRECTALLOCATION_ENABLED` supported envvars See #173
guizmaii
added a commit
that referenced
this pull request
Nov 17, 2024
…LING_DIRECTALLOCATION_ENABLED` supported envvars See #173
|
@er1c Thanks for these improvements 🙏
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratching my own itch, noticed we stopped getting some profiling despite having the environment variables set. Or was enabled when we disabled it in our deployment (via env). Hopefully should be straight foward.