-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamo v2: featuring aws-sdk-go-v2 #232
Conversation
* using sdk-v2
The official API doesn't accept int64 limits.
* Recover DYNAMO_TEST_REGION * Error handling * No extra type
Query/Scan.limit isn't bound by DynamoDB API limits, so it can exceed MaxInt32 Make scan segmentation > MaxInt32 an error
@guregu Any reason you are holding this PR open any longer? |
There were some encoding bugs that should hopefully be all taken care of now, haven't heard anything new. Has anyone tried running this (even against their test suite)? Would be nice to get some feedback. |
My team has prioritized testing this on our infrastructure for you. We will be able to work on this over the next several business days. Are there any specific tests that you would like us to run for this, or just generally make sure it is working as expected? |
Awesome, thank you! Much appreciated. |
Unfortunately, our use case does not include custom encoding nor practically any concurrent modification. But I can confirm that running it on our code base works as expected! |
That is good news, thanks. It looks like we are ready then. I'll make the release this week, within a day or two, as soon as I get some free time. |
(This is a continuation of #206, fresh PR without merge conflicts).
At last, the long awaited dynamo/v2! This keeps mostly the same API as v1 but uses the new AWS SDK.
Changes:
context.Context
now, removed...WithContext
methodsint
instead ofint64
for limitsPagingIter.LastEvaluatedKey
can return an error now (in exceedingly rare circumstances, but better safe than sorry)KMSMasterKeyArn
renamed toKMSMasterKeyARN
I believe v2 should be ready for testing now. You can try it out now with:
go get github.com/guregu/dynamo/v2@v2-dev
I would really appreciate it if people test it before the official release.
I will release this after I get some feedback. Or, if I don't get any, within a few weeks.