Fix Query.One + Filter behavior (#248) #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #248
When
Onecan't use the GetItem API, it triggers a Query. Previously these would only check one results page, which interacted poorly withFilter, potentially dropping results in large but empty datasets. Now, we iterate through pages until we find a result.ErrTooManyis emitted on a best-effort basis.To preserve the old behavior, use
RequestLimit(1)orSearchFilter(N).@dharkness please take a look and see if this helps your use case. This is the simplest way I could think to implement it. I think the root cause was simply that One was written without Filter in mind, much of its code untouched for 9 years.